When the Factory cannot or may not approve, the Maintainer approves by hand as the machine user (#198's ruling 5, record 0198)

Merged
DO
5d ago
+145-3

User description

This tells the cut-a-release skill what to do when the Factory cannot or may not approve, and records what the Maintainer's own approval is while he authors every pull request. It is working ruling 5 on "The ruleset switch: main requires the machine user's approval of the most recent commit, and slice 1's event is recorded" (#198), and the second half of what "The Maintainer's continue or stop is recorded in a file, and a decision counts only in his name (#198's ruling 7, record 0194)" (#739) was split from; that one merged as 8d9ee9e9. Part of #198; it does not close it.

Model-Lens inputs touched: none. The change is the skill, the root AGENTS.md row that points to it, one test, mutants and a record.

This pull request is meant to merge by the Maintainer's hand, with the Factory paused. Ruling 5 shows recovery once, on this pull request: he sets FACTORY_PAUSED, a pass records the Pause, he approves the head by hand as the machine user, his login enqueues it, verify passes on the merge group, and he sets the variable back. It opens labelled factory:hands-off so the Factory does not approve it first; the label comes off at the Pause. What is read of each step goes into the one comment on the epic, drafted for his word.

Size. 23,387 characters and 231 lines by git diff; 24,634 characters as the Kernel counts a diff, with its lines numbered, against a budget of 60,000.

What the skill now says

"When the Factory cannot approve", two cases:

CaseWhat is done
A change the Factory may not approve: one to a model Lens's inputIt goes to the hand approval once verify is green and its threads are resolved, with no rollback. No Pause is needed while config/controller.json names no queue account; once one is named, the Maintainer sets the Pause before the enqueue and lifts it after the merge
A Release that cannot approve1. The Pause, and the pass that holds it read before going on. 2. A rollback of next, if an earlier Release served; the Pause is lifted and that Release approves the fix. 3. Only when no Release can serve, the hand approval; the Pause stays until a Release cut from the fix is on next
  • The hand approval is the Maintainer's alone: by hand, as the machine user, in a browser signed in to that account. It needs no Release, no Run and no stored token.
  • It alarms. The next pass raises write_unmatched for it. He matches the entry to the approval he gave; every entry is read while the alert stands, and one that is not his asks for the token's rotation. The match clears nothing else: the design's rule, rotation on any reconciliation alert, stands for his own entry too until he says otherwise, and no session rotates or revokes the token.
  • Under a Pause the Factory takes nothing out of the merge queue, so what else is in it is his to stop.
  • A session stops before the approval, hands him the steps, approves nothing, signs in to no account and sets no variable. The section gives nothing to run.

Record 0198 says the same as a decision, and what it rests on: 0008, 0052, 0061 and 0191.

Three things for a ruling

  • The rotation rule. The design asks for the machine user's token to be rotated on any reconciliation alert. Every hand approval raises one. The Factory Builder ruled on 2026-11-11 that the rule stands and that no session rotates or revokes the token; the skill and the record now say so. Whether a matched entry should stop asking for it is the Maintainer's to say.
  • The cut under a Pause. The skill's earlier line says a cut waits under a Pause. In step 3 the Pause stays until the new Release is on next, so that cut is his own dispatch under the Pause. Lifting the Pause first would let the broken Release serve again. This is my reading of ruling 5, not its words.
  • Where the by-hand ruling is written. The record rests the first case on the Maintainer's ruling of 2026-11-11, which the Factory Builder relayed to this lane. It is not on #198.

Checks it adds

  • tests/test_release.py::test_when_the_factory_cannot_approve_the_skill_leaves_the_approval_to_the_maintainers_hand_and_runs_nothing holds the section word for word, by its digest, and by name: the three steps in order and no other; who sets the Pause; who approves, as whom and with no stored token; the alert; and no fence, indented block or span that could be run.
  • Fourteen mutants of the section, each killed by it.

Checks

CheckResult
make checksOK, at 68ec63c
tests.test_releaseOK, 34 tests
Mutants of the skill, run alone on an export15 of 15 killed, at 68ec63c
Full make verifyNot run locally, by the Maintainer's standing change of 2026-11-09; CI's verify is the answer
ReviewerHeadUnread partsBlockingMajorMinorInfo
agy (Carbon)8662238none0110
muse8662238none1200
claude-review8662238none0232
claude-security8662238none0130
agy (Carbon)49e181anone0000
muse49e181anone0000
claude-review49e181anone0022
claude-security49e181anone0020
astra3565878none0000

The section was rewritten after the first reads, so all four read again. Astra read the head after the second reads' fixes. Since then the branch was rebuilt on main once #739 had merged, and its record renumbered, on the Factory Builder's word, as other lanes' records merged first: from 0194 to 0195, to 0196, to 0197, and last to 0198 (68ec63c). Each changes one number in the skill's section and so its digest in the test; nothing else of the section changed for the number, and no reader read again. Records 0195 to 0197 are on main and main is merged in, so the records run with no gap.

FindingWhatDisposition
muse #1, agy #1, claude-review #2, security #4 (first reads)With no Pause, the Kernel's Decision on a hand-approved change to a model Lens's input in the queue is to take it outfixed: the skill and the record say so, and that nothing carries it out while no queue account is named; once one is, the hand merge is under a Pause
security #1, claude-review #1 (first)The record said nothing raises a hand approval; reconciliation is built and raises write_unmatchedfixed: the record's row "What follows a hand approval", and the skill
muse #2, #3, agy #2, security #2, #3, claude-review #5 (first)A stored token, a command in prose or double backticks, a session setting the Pause each survived the testfixed: the section is held word for word, with a mutant for each
claude-review #3 (first)Not every item reads paused under a Pausefixed: the pass's record holds the Pause, and an item a Run or an act was due on reads paused
claude-review #4 (first)The cut waits on the Pause and the Pause on the cutfixed as above, and put for a ruling
claude-review #6 (first)The record said a Pause leaves the Factory approvingfixed: only the rollback does
claude-review #7 (first)Nothing leads a session with such a change to the sectionfixed: the root AGENTS.md row and the skill's description
security #1 (second)One standing alert hides a later use of the loginfixed: every entry is read while it stands
security #2 (second)A Pause stops every dequeuefixed: the queue is his to stop while it stands
claude-review #1 (second)The test failed on the day a queue account is named, though the sentence stays truefixed: that assertion and its mutant are gone
claude-review #2 (second)Does a matched alert still rotate the tokennot decided here; put for a ruling
claude-review #3 (second)A mutant's name said more than it didfixed: it moves the hand approval to the second step
claude-review #4 (second)The by-hand ruling is not on the issuesaid above, for the Factory Builder

Review threads, six, all resolved

ThreadDisposition
gemini: read the skill with an explicit encodingnot changed: every read of the skill in the file is written the same way, and the repo is verified in UTF-8 alone
cubic: the Status does not name the rows of 0052 and 0055 it amendsit amends none; the Status now names both and says they are as they were (18a71bf)
cubic: the skill omits what a matched alert does to the rotation rulefixed in 18a71bf, with two assertions and a mutant
cubic: the cut under a Pause contradicts "a cut waits"fixed in 18a71bf: "Before anything runs" names the one cut the section has him dispatch under it
codeant: a job that passed its check before the Pause can still writefixed in 34f0ffa: the Pause step has the pass that holds the Pause read before the next step
codeant: rotation is limited to entries not hisalready fixed in 18a71bf, as cubic's

🤖 Generated with Claude Code


CodeAnt-AI Description

Document manual approvals when the Factory cannot approve a change

What Changed

  • For model-input changes the Factory cannot approve, the Maintainer can approve by hand once verification passes; no rollback is needed. A Pause is required before enqueue only when a queue account is configured.
  • For a Release the Factory cannot approve, pause the Factory and roll next back to an earlier Release when possible. Use hand approval only when no Release can serve, and keep the Pause until a Release containing the fix is on next.
  • The Maintainer approves in a browser as the machine user; verification on the merge group is still required, and a session never performs the approval. The next pass flags the unrecorded approval, and every alert entry must be reviewed.

Impact

✅ Model-input changes can merge without a rollback
✅ Broken Releases stay paused until a fixed Release serves
✅ Unrecorded approvals are reviewed entry by entry

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.