The approving act names a Pause the port could not read by the port's part (#688's dry runs 5 to 7, record 0192)

Merged
DO
6d ago
+175-15

This is the second half of #728, "A Pause the port could not read is named by which read it was and why", split in two to stay under the Factory's review budget. The first half, #729, gave the Pause's port its parts and merged as be4992d7. This half makes the approving act name them, and carries the decision record. It is hardening, not a fix.

Why

Slice 1's dry runs 5, 6 and 7 on "AGENTS.md: say what is built; drop the model claim no check holds" (#688) each stopped in the approving act, at facts_unreadable twice and then at pause_unreadable: the Pause, and not which of its two reads, or how. The cause was the machine user's token, whose Variables grant was waiting for the org's approval. A code that said "GitHub refused the list of the org's variables" would have pointed at the grant at dry run 5.

What this half changes

  • harness/reread.py: item takes name_pause. Asked, it reads the Pause through the port's explained and raises a Pause the port could not read as a read of the pause stage, its part the first unreadable scope's, the org's before the repo's. It raises after the run records are found unread, and never while a scope pauses.
  • harness/approve_step.py asks by name, so the act records pause_<part>_unreadable through unread in harness/shared.py, as it records a snapshot's part: pause_org_refused_unreadable, pause_org_unnamed_unreadable, pause_repo_refused_unreadable, pause_org_unreadable or pause_repo_unreadable.
  • Record 0192 amends 0179's row "The parts" and 0187's row "A part not as its schema holds it", for the Pause. Its boundary rows name the first half's test and mutants as well as this half's.

What does not change

  • The Controller: read hands back what it did, so pause_unreadable is still its one code.
  • Apply: it does not ask by name, and names its Pause in its own order.
  • The outcome's kind: only the approving act's reason is finer, so no Decision moves.
  • In the approving act, pause_unreadable is left for a Pause the port read whose value is no Pause, and for a fault of the read's own code.

One order does change, and the record says so: a Pause the port could not read is now raised by the read again, so the act names it before it holds the run records and the snapshot to their schemas, as it does any read that raised.

Checks it adds

  • tests/test_steps.py::test_the_item_is_read_again: asked by name, each part is raised at the pause stage; not asked, nothing is raised; a scope that pauses, a value that is no Pause and a Pause read clear raise nothing; unread run records are named first.
  • tests/test_steps.py::test_the_approver_holds_to_its_item and ::test_an_approving_run_finds_its_act_by_its_run_name_and_approves: the step asks by name, and ends pause_org_refused_unreadable on a refused list.
  • tests/test_steps.py::test_apply_reads_with_reads: apply asks for no part.
  • tests/test_approve.py::test_each_fault_of_the_act_is_classed_as_the_design_classes_it: the five codes.
  • Twelve new mutants, each killed by a test its record row names, and one older mutant of harness/reread.py reworded to the text as it now stands.

Checks

CheckResult
make checksOK
tests.test_effects, test_steps, test_approve, test_controller, test_apply, test_token_needsOK, 165 tests
Mutants of adapters/pause.py and the five touched files under harness/, run alone on an export146 of 146 killed, at 554f3e6; the head, 1f63a2e, differs from it in one sentence of the record
Diff31,948 characters and 362 lines, under the Factory's review budget
Full make verifyNot run locally, by the Maintainer's standing change of 2026-11-09; CI's verify is the answer

Reviews

The five readers read this code on #728. This half's files are #728's at ff8e4f4 but for the record's number, 0192 where it was 0191, and one sentence of its Status, which a review comment on this pull request had put the title before the number in. So no reader read again.

ReviewerHead on #728Unread partsBlockingMajorMinorInfo
agy (Carbon)ec6c7a5none0420
museaa0e10dnone1100
astradd12cb2none0000
claude-reviewaa0e10dnone0021
claude-securityaa0e10dnone0000

Every finding and its disposition is in #728's description. Those that touched this half: the placeholder number (Muse, Carbon), now 0192 by the Factory Builder's ruling that numbers go in order of readiness; unread's docstring (the Claude review); a mutant for the read again's own call of the port (Carbon); and Carbon's minor asking for a mutant of harness/approve.py, which is no change, since only its docstring changed and the code is formed by unread.

šŸ¤– Generated with Claude Code