Config: no author Role is named until its manifest exists, so no fix Run is dispatched to a missing Role (#675, record 0189)

Merged
DO
7d ago
+118-2

Closes #675, "author_role is null until roles/dev-lead.json exists, so a fix Run is never dispatched to a missing role". It holds decision record 0189. The protected edits to config/defaults.json and sim/world.py are pre-approved by the Maintainer 2026-11-08, ruled by the Factory Builder.

What changes

WhatNow
config/defaults.jsonauthor_role: null. The Kernel decides no fix Run (kernel/decide.py's _wanted_run), so an item with an open blocking Finding or a failed check has outcome nothing and waits for a person. Before, each fix Run failed at harness.read with file_unreadable, on every pass up to the Run ceiling of 10 an item, and three such faults trip the automatic Pause
tools/check_authority.pyRefuses a configured author_role or owner_role that is no Role's name as role/1 spells one (so none reaches outside roles/), or that has no file under roles/. The owner is always named; the author may be none. A named author Role is the authority table's, as before
tests/support.py, sim/world.pyTake the author Role from the authority table. The simulator models the Factory once dev-lead exists, and the Kernel's fix path stays held with a Role in place. The live configuration defers each fix to a person until then, which a new test reading the real configuration holds

The record names when this changes back: the pull request that adds the author Role's manifest, waiting on roles/dev-lead.json, names it again.

Checks

  • tests/test_decide.py::test_the_configuration_names_no_author_role_until_its_manifest_exists: with the real configuration, an open blocking Finding and a failed check each give addressing with outcome nothing and no admission.
  • tests/test_tools.py::test_a_role_the_configuration_names_has_a_manifest.
  • Ten new mutants. At b5208ec5, every mutant of config/defaults.json and tools/check_authority.py is killed. make checks and check_decisions are clean, apart from the record gap until 0185 to 0187 are on main. The simulator's and the Kernel's tests pass. CI runs the full verify.

Renumbered 0188 → 0189 in 0504b334, as the Factory Builder ordered the queue (the approval-step fix takes 0187, #713 0188).

Reviews

ReaderHeadFindingsDisposition
Argon (gemini-4-argon-high)fb4e1888None—
Muse (muse-wonder-full-1.0)fb4e18881 blocking: the record named a path not yet in the repo, and the context check refuses that; 1 major: a role name with ../ named a file outside roles/; 1 minor: the check allowed a null owner RoleAll fixed in d250b986, with tests and mutants
Astra (gpt-6-astra)d250b9861 major: a name that only begins as a Role's passedFixed in b5540a15, with a test and a mutant
Astra, second readb5540a151 major: no test accepted a validly named author RoleFixed in 53ee2be2, with a test and a mutant
Astra, third read53ee2be21 major: no test told a manifest file from a directory of its nameFixed in daf849e0, with a test and a mutant
Astra, fourth readdaf849e01 major: no test refused a name ending in a hyphenFixed in b5208ec5, with a test case and a mutant. No further read: four reads found only a missing test each

šŸ¤– Generated with Claude Code