A check's App another App's token is not shown reads as null, and is never a Lens's (#688's second dry run)

Merged
DO
7d ago
+231-14

Slice 1's second dry run, on "AGENTS.md: say what is built; drop the model claim no check holds" (#688) at v0.1.2, stopped in the reader at snapshot_checks_unreadable. Run 42742314675 made no model call. This is the fix the Factory Builder ruled on 2026-11-10: one change that covers both readings of that stop, with no probe first. v0.1.3's run is the probe, and the stage codes from #694 stay, so a run that still stops names which refusal it is. It opens labelled factory:hands-off.

Why

The Factory's three Apps are private: an anonymous GET /apps/<slug> answers 404 for the controller, the reader and pr-review. #688's head holds 27 check runs and no commit status. One of them is factory, the Controller's own status. The reader asks for each check run's checkSuite.app and may not be shown the Controller's private App. GitHub then gives it null, or refuses it as FORBIDDEN, and the checks read refuses the whole rollup. The Controller is shown its own App, so its pass reads the same query whole. Once pr-review posts a check run of its own, the Controller's pass would stop the same way.

Ruled out:

  • A missing statuses grant: the head has no commit status, and no StatusContext is in the rollup.
  • A difference in path: the pass runs the same checks.QUERY through facts_.snapshot.

What

WhereWhat
adapters/checks.pyA check run whose suite's App GitHub gives null reads as app_id null. So does one refused as FORBIDDEN at exactly that check run's checkSuite.app: the place is matched part for part, type included. A refusal of any other type, place or page refuses the read, as before. So does a refused App the rollup gives anyway, one with no rollup, a place outside the page, and an App object with no id
schemas/facts.schema.jsonapp_id is an integer or null
adapters/seen.pyA check run whose App is null leaves what was seen short, never silent (0061, 0063), on the snapshot's path and on a left item's REST path
adapters/acceptance.pyA result's check with no App is still refused
The KernelUnchanged. A null App under a required Lens's check name is <lens>:from_app:unreadable, a deferral (test_a_check_from_another_app_is_unreadable_for_its_lens). On the Controller's status, or any check no Lens names, it changes no Decision (test_a_check_no_lens_names_whose_app_is_not_shown_changes_no_decision). So nothing becomes admittable that was not before
docs/decisions/0181-…The record
tools/mutants.py17 new mutants; two repointed at the changed text

Verification

  • make checks: ok.
  • Mutants run alone on an export: 130 of 130 on adapters/checks.py, adapters/seen.py and the new Kernel and acceptance mutants at 1dba7d9, and the status-context mutant killed at e824483.
  • CI's verify is the answer, per the Maintainer's standing change of 2026-11-09.
ReviewerHeadUnread partsBlockingMajorMinorInfo
agy (Argon)013e5e7none0200
muse013e5e7none0210
claude-review013e5e7none0121
claude-security013e5e7none0110
claude-review45139aanone0010
claude-security45139aanone0010
claude-securityc3ba7fdnone0000
astrac3ba7fdnone0100
astra4aad943none0200
astra1dba7d9none0100
FindingWhereWhatDisposition
claude-security@013e5e7 #1, claude-review@013e5e7 #1, muse@013e5e7 #2 (major)adapters/seen.pyA null App left reconciliation whole, silentlyfixed in 45139aa: short, with a test and a mutant
muse@013e5e7 #1 (major), claude-review@013e5e7 #2adapters/checks.pyAn App object with no id read as nullfixed in 45139aa: refused
claude-security@013e5e7 #2, claude-review@013e5e7 #3 and #4, muse@013e5e7 #3, agy@013e5e7 #1 (major)adapters/checks.pyA refusal with no rollup, or at a negative place, was takenfixed in 45139aa
agy@013e5e7 #2 (major)adapters/checks.pyA refusal at a place holding no object crashedfixed in c3ba7fd: refused
claude-security@45139aa #1, claude-review@45139aa #1adapters/seen.pyA left item's REST check run with no App id stayed wholefixed in c3ba7fd
astra@c3ba7fd #1 (major)adapters/checks.pyfalse or 0.0 for the commit's index matched the placefixed in 4aad943: matched by type too
astra@4aad943 #1 (major)adapters/seen.pyA check run whose App id is malformed, not null, still read wholefixed in 84a34f3 and 1dba7d9: short unless the id is a positive whole number, on both paths
astra@4aad943 #2 (major)tests/test_adapters.pyNo case held a check run's place to a whole number, never falsefixed in 84a34f3: the case and its mutant
astra@1dba7d9 #1 (major, a test gap)tests/test_adapters.pyNo case held a refusal of a status context's App to refusingfixed in e824483: the case and its mutant; by the Factory Builder's ruling, no further read for a test gap

šŸ¤– Generated with Claude Code