Workflows: the pass, the Run's three jobs and the approving act's job, each held word for word and each running one Release (#196, PR 2b-2)

Merged
DO
25d ago
+1102-68

What

The second part of #196's PR 2b: the workflow files that run #334's steps, each held word for word by tools/check_workflows.py. Record 0066 (#336 holds 0065). Dormant: nothing calls these files until PR 3's shims, which land under the Maintainer's Pause.

FileHolds
.github/workflows/pass.ymlOne job, pass, on factory-poller, with actions: write. It checks out the Channel with its tags, runs python3 -m controller with CONTROLLER_APP_KEY, and uploads pass/1 as pass before anything is dispatched. It then runs the writes with the key and the pass's own token, and uploads written/1 whatever failed
.github/workflows/run-jobs.ymlrun on factory-run: the Channel checked out once, the commit handed on (python3 -m harness.steps), the CLI installed, the reader's step with READER_APP_KEY, the Engine's step with CLAUDE_CODE_OAUTH_TOKEN alone, and the Result uploaded. verify: no secret and no cache, and that exact commit checked out with tags. apply on factory-apply: if: always() once the commit is handed on, NEEDS, its steps under if: always(), and the outcome's upload last
.github/workflows/approve-job.ymlapprove on factory-approve, with APPROVER_TOKEN alone. Its outcome is left by the same last step as apply's (decision 0055's file)

What the check holds:

  • Each file word for word, comments excepted.
  • The CLI at the Engine's pin, with its sha256 for that version in CLI_CHECKSUMS. 2.1.306's value comes from the vendor's release manifest for linux-x64, and a pin with no entry is refused.
  • Each key and its environment named only in its one file, in any case.

The Release's name, as ruled on 2026-10-26 after #197's ruling 11:

  • The first job checks out the Channel once and hands on the commit.
  • Every later job checks out exactly that commit, with tags.
  • harness/steps.release, the one entry point, reads the one factory/vX.Y.Z tag at HEAD. The Channel tag doesn't count. None or two refuse before any key.
  • The entry, apply, the outcome and the act read it there. release/current.py replaces it, and the record states the accepted miss.

Other changes:

  • No-argument forms: each step got one for the workflow, because a run: line is python3 -m <module> alone. It reads NAME, ITEM and PASS from env and uses fixed folders. run hands its digest on as its step output.
  • Pass token account: config/controller.json's workflow_token is now github-actions[bot] (41898282, from P-9), as ruling 10 has this PR set it. test_reconcile names the unset account where it means it.
  • Rows: every row waiting on run.yml or run-jobs.yml is re-pointed to its test. 0005's row keeps an item branch's own workflows waiting on adapters/settings.py.

Departures to note

  • Checkout: every job checks out the Release. Decision 0055's "no ref: checkout" is read as "never the item's code".
  • 0050: its Boundary says the workflow sets the scrub. The Engine sets it, and the check forbids any step from setting it. Only the Check cell is re-pointed.
  • 0036: its Boundary has the Run's start re-read the run list before it asks the Kernel. The Run's start asks the Kernel nothing, because its reader holds the Decision. The Check cell says so; the Boundary would need a new record.
  • A failed early checkout: if run's Channel checkout fails, apply doesn't run and the Run leaves no outcome. It is read as a failed attempt, which the Run ceiling bounds, and is recorded in 0065.

For the Maintainer: code-scanning alerts to dismiss as false positives

  • #36 and #37: CodeQL's "Checkout of untrusted code in a non-privileged context" on .github/workflows/run-jobs.yml, verify's and apply's checkout of ${{ needs.run.outputs.commit }}.
    • That output is written by one step alone, commit, right after run checks out the Release channel. It runs the Release's own code, before the CLI or any secret, and GitHub keeps each step's outputs apart, so no later step can write it.
    • Each later job then names its Release from the commit before any keyed step: verify refuses a commit with no Release tag, and apply's step refuses before it reads its key.
    • Held by tests/test_tools.py::test_the_commit_a_later_job_checks_out_is_the_releases_own and decision 0066.

Gates

  • Claude review with a security pass: 6 findings, all fixed. The high one: the key rule was case-sensitive.
  • Argon: no findings, on the head after main was merged in.
  • Muse: not run, since this is workflows only (the Builder's call).
  • Mutants: 30-odd new, each killed by hand.
  • Export verify at 21e6eac: 1186 tests, OK. To be re-run on the head once #336 (0065) lands.

šŸ¤– Generated with Claude Code