feat: implement issue #638 — SonarCloud: JavaScript/TypeScript code quality

Merged
DO
1mo ago
+27-21

Problem

SonarCloud: JavaScript/TypeScript code quality

From the issue: 1 open SonarCloud finding(s) in combsmith/google-app-scripts, worst severity CRITICAL. Generated by the org SonarCloud Audit.

Risk

Low — 8 file(s) changed; no CI- or runtime-critical paths touched.

Test plan

Tests added/updated: src/gmail-to-drive-by-labels/tests/gas-utils.test.js. Verification: bash scripts/dev-lead-lint.sh (shellcheck --severity=warning) ran pre-commit; the bats suite runs in CI.

Rollback

Revert this PR. No non-revertible side effects (no tags, migrations, or external state).

Monitoring

This PR's CI checks (Lint + bats) are the success/regression signal.

Closes #638

Summary by CodeRabbit

  • Enhancements

    • Attachment content deduplication now uses SHA-256 fingerprints instead of MD5, improving hash strength while preserving the existing duplicate-detection workflow.
  • Documentation

    • Updated architecture, component, and processing documentation to reflect SHA-256 hashing.
  • Tests

    • Updated hashing tests and test utilities to validate SHA-256 results across supported file and blob inputs.