[pull] master from rust-lang:master
Merged
PU
4mo ago+201+201+012345678901234567890123456789-8-8-0123456789
See Commits and Changes for more details.
Created by pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? đź’– Please sponsor : )
Summary by cubic
Fix timing reports to only include units the job queue actually ran and to handle no-work sessions correctly. Removes zero-duration rows and clarifies behavior between --timings and cargo report timings (fixes #17212).
-
Bug Fixes
- Report only units that started; exclude fresh units and those run outside the queue, and drop references to non-started units.
--timings: always writes a report; shows an empty dataset (const UNIT_DATA = [];) when nothing ran.cargo report timings: errors on logs with no units with “no timing data found in log”.- Added
error_if_no_unitstoprepare_contextand updated call sites to set it appropriately.
-
Tests
- Doctest units are not reported as zero-duration rows.
- Fresh rebuilds produce an empty dataset instead of zero-duration rows.
- Idle sessions:
cargo report timingserrors;--timingsstill generates an empty report.