ci: avoid rerunning TypeScript unit tests

Merged
AN
2mo ago
+1-4

Change

The TypeScript unit job currently runs turbo run test:unit and then runs root vitest run. The second command repeats the package unit tests, so this change removes it along with the unused Chrome output ID.

Chrome setup and the separate browser job remain unchanged.

The baseline repeated root Vitest step took 81 seconds after Turbo unit tests had already completed. With this change, the TypeScript unit job took 2m 53s, compared with 4m 16s in the baseline.

Coverage check

We verified that removing the root Vitest run does not drop the relevant unit coverage:

  • Root Vitest collects 239 test files; Turbo's test:unit tasks collect 240.
  • 235 files overlap.
  • The four root-only files are all in packages/sdk-ts/tests/browser-runtime, which is already covered by the separate test:browser task.
  • The Browserbase smoke test is also run separately with BROWSERBASE_SMOKE=1.
  • At the test-case level, all 33 root-only cases are browser-runtime tests.
  • Turbo additionally covers 11 example integration-facade cases that root Vitest doesn't select.
  • Package-level Vitest configs can differ from the root config, so we keep each package's existing test:unit command rather than replacing it with the root config.

Validation

On a branch based on the current upstream main:

  • pnpm install --frozen-lockfile passed
  • pnpm build — 14 tasks passed
  • pnpm check — 36 tasks passed
  • pnpm exec turbo run test:unit — 33 tasks passed
  • The exact workflow change passed Build, Check, TypeScript unit, and all 32 integration jobs run 35329939833

The only fork limitation is the Browserbase smoke test, which requires BROWSERBASE_API_KEY.


Summary by cubic

Removes the duplicate root vitest run step from the TypeScript unit job so package unit tests run only once. The browser-runtime specs that root Vitest picked up are already covered by the browser-ts job, so coverage is unchanged.