Say what screening a sender out does to what they already sent

Merged
JE
2d ago
+4-2

What was wrong

In a Reflex eval run from basecamp/hey-native-apps (cust-unsubscribe-screens-out), the person asks their agent to "Unsubscribe me from the newsletters in my Feed." Their agent drives HEY through the app endpoint. It screened the senders out correctly, but in 2 of 3 runs it told the person that the issues already in their Feed "are still there". One earlier run called the senders "blocked" throughout, which is not a word the person can find in HEY.

screener deny's agent notes mention mail already sent only under --spam. That leaves "without --spam it stays" as the easy reading.

What HEY does

Denying a clearance destroys the examiner's postings of the sender's topics and rejects those topics. See haystack app/models/clearance/topics.rb, refresh_topics_now: postings_by_denied_petitioner_are_destroyed_for_examiner and non_spam_topics_are_rejected_if_denied_by_all_examiners. So the mail leaves the Imbox, the Feed and the Paper Trail for Screened Out, and approving the sender restores and refiles it (topics_are_activated_unseen_and_filed_for_examiner).

Change

  • screener deny's long help says that what the sender already sent leaves for Screened Out, and that approving brings it back.
  • Its agent notes ask the agent to tell the person the sender is "screened out", HEY's own words, and that their mail left with them.
  • The skill's app-mode line says the same for hey screener deny <email>.

Verification

  • make check passes.
  • scripts/skill-coverage/check.py reports the same uncovered facts as on main.
  • A Reflex play of that eval task, n=3, with hey built at this branch's head, is running. Its before and after will follow in a comment.

Summary by cubic

Fixes agents telling people that mail from screened-out senders is still in their Imbox or Feed after screener deny.

Updated screener deny's help text, agent notes, and the skill's app-mode line to state that screening a sender out moves what they already sent to the Paper Trail for Screened Out, and that approving the sender brings it back. The notes also instruct agents to use "screened out" — HEY's own term — rather than "blocked" or saying the mail is still there.