Hear a boost on the agent's line in a Ping
A boost on the agent's own comment in a project it serves reaches the agent. The same boost on the agent's own line in a Ping was dropped as no_route, and the person who boosted saw no sign of it. A Ping is never a served project, and the boosted rule required one.
Basecamp card: Boosting an agent's line in a Ping never reaches it, and nothing says so
What changes
- The boosted rule now has
HeardInPings. For the connector that hears the agent's Pings (--pings), the gate keeps the rule open outside a served project.Decidethen asks the Ping read, the same read a line gets. - A boost is admitted there only when the bucket is a Ping, the boosted line is the agent's own, and the booster is someone who can already mention the agent in that Ping: an operator, or a person
--allow-in-pinglet into that one Ping (as a participant). - Unchanged: a boost in an unserved project is still discarded as
no_route, and a connector that doesn't hear Pings still discards it before any read. Agents, delegated boosts and a booster who isn't the performer are refused as before. A project member under project trust is still nobody in a Ping. - As in a project, the operator's own boost names the line as the ask it would answer, so a declared ask in a Ping can get its go. Any other booster's boost names none. A boost is never
Owner, so it never counts as the owner's word on the connector. subagent.mdno longer says a boost in a Ping never reaches the agent.
Cost
When a connector hears Pings, a boost in a project it doesn't serve now costs one Ping read before it is discarded. Before, it was discarded with no read. A chat line there already costs that read.
Tests
ping_boosts_test.go covers:
- the operator's boost in a direct Ping and in a group Ping
- a participant's boost
- boosts on someone else's line
- a person let into a different Ping
- a member under project trust
- agents and delegated boosts
- a connector that doesn't hear Pings
- an unreadable connect.json
Against main, the admitting cases fail. TestABoostSettledFromItsPointerCostsNoRead now pins the one Ping read when Pings are heard, and still pins zero reads when they aren't. bin/ci passes locally.
Summary by cubic
Boosts on the agent's own line in a Ping now reach the agent. Previously, they were discarded as no_route: a Ping is never a served project, and the boosted rule required one.
- The boosted rule is now
HeardInPings: a connector that hears Pings asks the Ping read, and admits the boost only when the bucket is a Ping, the line is the agent's own, and the booster is an operator or a participant let in with--allow-in-ping. - Boosts in an unserved project are still discarded as
no_route, and a connector that does not hear Pings still discards them before any read. - Agents, delegated boosts, and boosters who aren't the performer are refused as before; a project-trust member is still nobody in a Ping.
- The operator's own boost in a Ping may answer a declared ask, as in a project; it is never the owner's word.
Cost
When a connector hears Pings, a boost in an unserved project now costs one Ping read before being discarded. Previously it was discarded with no read.