Show approximate 3D buildings during navigation

Merged
FC
20d ago
+206-11

Summary

Add subtle grey building volumes from zoom 17 during road guidance and transit walks. Existing OpenFreeMap tiles combine mapped heights and estimates from floor counts; these are approximate context, not surveyed measurements. Exclude their generic 5 m fallback conservatively, including indistinguishable genuine 5 m buildings. No new provider, dependency, permission or native code.

browse / plan / transit ride / overview at any zoom → flat footprints
road guidance / transit walk at z17+ → approximate grey volumes
pan during guidance → keep buildings; recenter → restore follow
Stop → flat planning map

Route layers follow the extrusion. The pinned Native renderer disables depth testing for subsequent 2D layers; observed Android views retain the route, casing, junction arrow and puck.

Evidence

  • Before: feature regressions failed (15 pass, 5 fail, 1 missing-module error). Review exposed overview retaining volumes on short routes; its regression failed (5 pass, 1 fail).
    After: focused suites pass (25 tests); final bun run verify with pinned Bun 1.4.3 passes typecheck, zero-warning lint and all 556 tests.
  • Android 16 AOSP development client, unchanged native beta.2 modules: 1 Hz synthetic walking fixes, first 110 m of a central Turin route at 1.4 m/s. Inspected building rendering, route/arrow/puck visibility, live light/dark changes, overview/recenter, free-camera pan, zooming out and Stop cleanup. Screenshots and recording retained outside Git; delivery notes record the observations and next-beta field checklist.
  • Independent standards and spec reviews completed. Overview was fixed with a regression. The final product contract explicitly allows tagged heights and floor-derived estimates while excluding defaults. Native rendering checks address the visual acceptance gap.
  • Physical readability, GPS, battery and smoothness remain field checks. The emulator's sparse Android UI frame sample was slow and does not establish native map pacing. Separate cycling, driving and transit-walk replays were not performed for this increment.
  • New feature: no originating field-report bug. Kotlin/JVM and Rust harnesses were not run because native code and guidance policy are unchanged; Cargo is unavailable.

Merge Danger

Door: two-way

Reverting restores flat buildings; no persisted state changes.

Blast Radius: navigation

Approximate volumes add GPU work and can differ from actual buildings. They remain subordinate to guidance, and browsing/planning/overview remain flat. Physical performance is explicitly unverified.

Summary by CodeRabbit

  • New Features
    • During active road guidance and transit walking, approximate grey 3D building shapes appear from zoom 17 when height or floor-count data is available.
    • Building shapes fade in as you zoom in; route lines, markers, and labels remain visible above them.
  • Limitations
    • Buildings with default or unsuitable height data remain flat. Browsing, planning, route overviews, and transit rides continue to show flat buildings.