test(mac): stabilize Oracle shell fixtures under concurrent Rust suites

Merged
TH
9d ago
+41-8

Scope

Stabilize three quick Unix shell adapter fixture tests under heavily parallel
macOS workspace runs. The former 1-second timeout produced two spurious
failures on Mac while the same target passed two consecutive isolated runs.
The tests now share a 5-second fixture-only timeout constant.

Explicitly unchanged

  • Production run_hl7_oracle_adapter caller-controlled timeout.
  • 20ms busy process timeout/kill test.
  • 100ms descendant process-group termination test.
  • Oracle stdout/stderr bounds, failure verdicts, expected process exit codes.
  • All protected AF-02 paths, other tests and GitHub workflow configuration.

Reproduction and qualification on the authorized Mac

Starting from canonical main f82565cca917d119e1c774b2c470e2ac20e0d6dd:

Before this change, full all-features workspace with the known AF-02
macOS-lint blocked test explicitly excluded failed with two oracle_process
tests: executable_adapter_accepts_valid_pinned_json returned
AdapterTimeout(1000ms), and malformed_adapter_json_fails_closed returned
the wrong error (also consistent with an adapter deadline instead of parsing).
The oracle_process binary passed 7/7 when run standalone, twice.

After this test-only change:

  • cargo +1.97.1 test --locked --workspace --all-features -- --skip af02_surface_scanner_is_locked_linted_tested_and_runnable:
    348 PASSED, 0 FAILED, 2 explicitly ignored, 1 filtered-out test,
    across 51 suites (Mac).
  • cargo +1.97.1 test --locked -p commandf-pkg --test oracle_process --quiet:
    7/7 PASSED.
  • cargo +1.97.1 test --locked -p commandf-pkg --test resolution --quiet:
    7/7 PASSED.
  • Cargo fmt and git whitespace diff check PASSED.
  • Alibaba OpenCodeReview v1.12.13 delegate preview selected the Rust
    test file. This is not an independent model-review pass; Jev NOT_RUN
    on Mac, no implied authorization for paid model calls.

The excluded AF-02/macOS lint issue is independently tracked in #215.
This PR does not cure issue #215, the intermittent live CF11 failure #214,
or independent human review requirements (#195).

GitHub-native signing verification is valid, author-matched DCO present.
Check exact-head CI and secure independent Code Owner approval before
any normal merge commit. Do not self-approve, squash, or bypass gates.


Summary by cubic

Shares a fixture-only 5-second timeout across the four quick shell-adapter tests in crates/commandf-pkg/tests/oracle_process.rs (previously 1 second, and 2 seconds for the oversized-stdout case), reducing spurious failures under heavily parallel macOS test runs. The production timeout remains caller-controlled, and the separate 20 ms and 100 ms process-termination tests are unchanged.