chore: clear out stale config and fix small doc and test gaps
Merged
GL
8d ago+30+30+01234567890123456789-25-25-01234567890123456789
What
Small cleanups, each checked against the code:
| Area | Change | Evidence |
|---|---|---|
.release-please-config.json | drop bump-minor-pre-major and bump-patch-for-minor-pre-major | they only apply below 1.0; the package is 3.0.0 |
.gitleaks.toml | drop the venv/ allowlist entry | .venv/ is the only virtualenv the repo uses and stays allowlisted |
pyproject.toml | drop the examples E501 ignore | ruff check . passes without it; no example line is over 110 |
pyproject.toml | drop the **/py.typed coverage omit and exclude_lines = ["pragma: no cover"] | coverage only measures .py files; the setting restated the default |
pyproject.toml | add [project.urls] (Repository, Changelog, Issues) | the PyPI page had no link back; the built wheel now carries three Project-URL lines |
dev extra | add pydantic-ai-slim>=1.83.0; pytest.importorskip("pydantic_ai") becomes a plain import | on a dev-only install those tests skipped silently; langchain-core is already in dev the same way. uv.lock gains two lines, no new package |
fetch_tools(mode=...) | typed ToolMode | None instead of Any, and documented | it was the one undocumented argument |
MIGRATION.md | the 3.0 hand-built tool snippet gets its imports | it raised NameError: name 'StackOneTool' is not defined when run; it runs now |
scripts/validate.sh | header names the default ADK checkout | it documented a different directory than the default it uses |
.github/dependabot.yaml | comment says the MCP SDK is ignored entirely | it said "major-only-blocked", but the ignore has no update types |
Tools._warn_duplicate_names | no change: the docstring edit was reverted, since #266 makes the warning fire once, when the collection is built |
No runtime behaviour change.
How verified
uv lock --check,uv run ruff check .,uv run ruff format --check .,uv run ty check stackone_ai examples: clean.uv run pytest(Python 3.13, all extras, MCP mock via pnpm): 871 passed, the same asmain; the pydantic-ai tests run rather than skip.uv build: wheel METADATA lists the three project URLs.- The MIGRATION snippet run as a script:
NameErrorwithout the imports, runs with them.
Gates (head d4f8132)
| Gate | Result |
|---|---|
| Repo skills | none in repo |
| /forge:forge | ran on c00a40b: removed the examples ruff ignores (ruff passes without them) and reworded the duplicate-name docstring; its typed sentinel exposed a private type in the public fetch_tools signature, so d4f8132 keeps `mode: ToolMode |
| Security scan | security-reviewer agent: no finding at confidence 70 or above. Aikido: 31 open issues on main (lockfile CVEs, workflow SAST, one old test-fixture secret), none on lines this PR changes |
| Codex security | clean on d4f8132 (job 772c9e76): the gitleaks change widens scanning; the release flags only applied below 1.0.0 |
| /security-review | ran: secrets, input validation, transport and DoS items clean; the server-side items do not apply to an SDK |
| /code-review | medium on d4f8132: no correctness bugs, 4 design notes. Declined: the mode annotation keeps a private type out of the signature, the dev pin mirrors langchain-core, and dropping venv/ widens gitleaks. Raised for a decision rather than changed here: the duplicate-name warning repeats on every adapter conversion, which is existing behaviour |
| CI | green on d4f8132: 10 pass, 3 skipped |
| Unresolved review threads | 0 |
Requested by guillaume@stackone.com in Slack (repo audit thread)
š¤ Generated with Claude Code
Summary by cubic
Cleans up stale config, fixes small doc and test gaps, and types the undocumented fetch_tools(mode=...) argument. No runtime behavior changes.
- Adds
[project.urls]topyproject.tomlso the PyPI page links the repository, changelog, and issues, and drops config that was stale or restated defaults (release-please pre-major flags, thevenv/gitleaks allowlist entry, the examples per-file ruff ignores, thepy.typedcoverage omit). - Adds
pydantic-ai-slimto thedevextra and replacespytest.importorskip("pydantic_ai")with plain imports, so those tests run on a dev-only install instead of silently skipping. - Fixes doc gaps in
MIGRATION.md(the 3.0 snippet raisedNameError) andscripts/validate.sh.