feat(toolset): inherit feedback from MCP, add disable flag
Draft
WI
9d ago+133+133+012345678901234567890123456789-635-635-012345678901234567890123456789
Summary
The StackOne MCP server now exposes submit_feedback as a global tool on every account (see unified-cloud-api PR #8507). The SDK inherits it straight from the MCP catalog (fetch_tools already lists from /mcp) and executes it through the same /actions/rpc path as every other tool — it no longer defines its own feedback tool.
- Removed the standalone
create_feedback_tool/FeedbackTool(which POSTed to the now-removed/ai/tool-feedback) and its tests. - Enabled by default on everything, disableable:
fetch_toolskeepssubmit_feedbackavailable even whenproviders/actionsfilters are applied (those are connector-keyed and would drop it), collapses it to a single instance across multi-account fetches, and removes it only whenfeedback=Falseis passed.
⚠️ Depends on
unified-cloud-api PR #8507 (global submit_feedback MCP tool + /actions/rpc dispatch). Draft until that merges — executing feedback 404s until then.
Test plan
- New
tests/test_feedback_tool.pypatches the MCP fetch so it doesn't depend on the vendored node mock: on-by-default,feedback=Falsedisables, survives provider filter, single instance across accounts.ruffclean. - Note: the vendored node mock server (
vendor/stackone-ai-nodesubmodule) only gainssubmit_feedbackonce bumped to the matching node release; when that happens, the existingtest_fetch_toolsintegration count assertions will each need +1 for the inherited feedback tool.
🤖 Generated with Claude Code
Summary by cubic
Inherit the global submit_feedback MCP tool across all accounts and remove the custom feedback tool. It’s included by default in both fetch_tools and search-and-execute builds, and can be disabled with feedback=False.
-
New Features
- Use MCP catalog
submit_feedback; executed via/actions/rpc. fetch_tools(feedback=False)to omit; kept regardless ofproviders/actions, single instance across multi-account fetches._build_tools(feedback=False)now appendssubmit_feedbackto the search/execute meta tools by default (sourced from the same cached catalog).
- Use MCP catalog
-
Migration
- Removed
create_feedback_toolandFeedbackTool(and/ai/tool-feedback). Usesubmit_feedbackfromfetch_tools()or via the default search/execute set.
- Removed