feat(panel): Settings… in the menu bar menu and ⌘, to open Settings

AD
6d ago
+38-3

Summary

Settings is two steps away from the menu bar (open the panel, find the tab). This adds Settings… to the menu bar menu and ⌘, inside the panel, both landing on Settings.

Changes

  • Menu bar menu: Settings… (⌘,) between Show panel and Check permissions…, calling the new PanelController.showSettings(category:).
  • ⌘, is a new case in globalKeyAction (.openSettings), per the keyboard rules in AGENTS.md. It works from a text field, is ignored while recording a hotkey and on a held key, and does nothing on screens with no tab strip (setup, update, Permissions opened from setup), like ⌘←/→.
  • README: key table and menu table rows.
  • GlobalKeyActionTests.test_commandCommaOpensSettings pins the key table.

Testing

Automated: ./build.sh (no new warnings), make test-without-xcode (1448 tests, 0 failures), make typecheck-tests.

Manual, after make reload:

  1. Click the bell in the menu bar. Choose Settings…. The panel opens on the Settings tab.
  2. Hide the panel, switch to Events, open it with the hotkey, press ⌘,. It switches to Settings.
  3. On Sessions, press / to focus the filter, then ⌘,. It switches to Settings.
  4. In Settings, select the hotkey row and start recording. ⌘, is recorded as the combo and does not leave the page.
  5. With the widget on and the panel collapsed to the pill, choose Settings…. The panel expands onto Settings.

Related issues

None.

🤖 Generated with Claude Code

Summary by cubic

Adds Settings… to the menu bar menu and a ⌘, shortcut in the panel, so users can jump straight to Settings instead of opening the panel and finding the tab.

  • ⌘, works from a text field and is ignored while recording a hotkey, on held keys, and on screens with no tab strip (setup, update, permissions from setup).