chore: stop passing rcx-* props to Fuselage components in the app

Draft
GG
12d ago
+4-18

Proposed changes

First migration step of the "Fuselage components take no styling props" proposal (#42974): the app stops passing rcx-* props to Fuselage components.

  • rcx-swiper-zoom-out/rcx-swiper-zoom-in (ImageGallery), rcx-sidebar-item__menu (SidepanelItem) and rcx-button--loading (RetryButton) match no CSS rule and no e2e locator: removed. SidebarItemMenu already puts rcx-sidebar-item__menu on the wrapper it renders.
  • rcx-field-group__item on CustomFieldsForm's Field is still needed: FieldGroup patches the class onto CustomField, which doesn't forward it. It becomes a className (Box merges both into the same class list, so the output is identical).

node packages/fuselage/scripts/scan-style-props.mjs (from #42974) reports no rcx-* prop outside Fuselage after this change. The 20 sites inside Fuselage belong to the proposal's "Fuselage's own compositions" step.

Issue(s)

https://rocketchat.atlassian.net/browse/ARCH-2583

Steps to test or reproduce

No visual change expected: image gallery toolbar, sidepanel item kebab, outbound message retry button, custom fields in registration/omnichannel forms.

Further comments