regression: user menu avatar clipped by the section header
Proposed changes (including videos or screenshots)
ARCH-2572
Since #42818, the menu renders section titles with ItemGroupHeader and ItemGroupTitle instead of OptionTitle. ItemGroupTitle hides overflow. The user menu header still had negative block margins (-8px top, -4px bottom) that cancelled the old OptionTitle padding. Those margins pushed the avatar past the top of the title, so its top edge and rounded corners were cut off and the avatar looked square.
This PR removes those margins. The avatar now keeps its 36px rounded shape, and its inline offset is still 12px. The header now has the new group header's 4px block padding, so it sits 4px lower and has 4px more space below than before #42818.
Issue(s)
Regression from #42818. That change hasn't shipped in a release yet, so this PR has no changeset.
Steps to test or reproduce
- Open the user menu by clicking the avatar in the navbar.
- Check that the avatar in the menu header has its rounded corners and isn't clipped at the top.
Further comments
The migration also changed the display name's color from the default text color to the group header's secondary text color. This PR leaves that as is.
๐ค Generated with Claude Code
Summary by CodeRabbit
- Bug Fixes
- Improved spacing in the user menu header by removing unintended extra margins.