regression: secondary sidebar item adjustments after the `Item` migration
Merged
JU
13d ago+14+14+01234567890123456789-13-13-01234567890123456789
Proposed changes (including videos or screenshots)
ARCH-2499
Fixes layout regressions in the secondary sidebar feature preview introduced by #42819:
- Rows did not reach the edges of the list. The row wrapper and the filter tablists added
paddingInline={4}, so the hover and selected surfaces stopped short of the edges and read as pills. The padding is removed. - Filters were misaligned with the rooms and group headers. The filters rendered a bare
Itemwithout an inset, while rooms and group headers use themdinset. They now renderSidebarItem, so all rows share the same inset. The filter dividers follow that inset (marginInline={12}). - The sticky group header was transparent. Before the migration the collapse group bar carried the sidebar surface; the
Itemgroup header does not, so rooms scrolling under the pinned header showed through it. The virtualized group wrapper now takessurface-sidebar.
All changes live in the application, under the feature preview's RoomList; Fuselage and other SidebarItem consumers are untouched.
Issue(s)
Regression from #42819 (unreleased), so no changeset.
Steps to test or reproduce
- Enable the secondary sidebar feature preview.
- Hover and select rooms and filters (All, Favorites, Discussions, omnichannel filters): the surface fills the full row width.
- Check that filter icons, group headers and room avatars line up.
- Scroll the room list: the pinned group header stays opaque over the rooms passing beneath it.
Further comments
๐ค Generated with Claude Code