Drop the inbox thread's "Waiting on you" marker

Merged
DA
5d ago
+57-75

PR 6 of the Inbox redesign rollout. Dean asked: "I also want to remove the 'Waiting on you' chip in the thread."

What changed

  • inbox-pane.tsx: AskMarker (the pill ending the agent's message) and Waiting (the line at the head of an ask of an unknown type) draw nothing when an open ask waits on the reader. The draft reply under the thread already holds the ask's controls, so it already shows the answer is theirs. WAITING_ON_YOU is gone, and the doc comments now describe the new behavior.
  • A teammate's item still shows "Waiting on " after a muted dot. Nothing else in the thread says who the item waits on.
  • desktop.css: removed .inbox-waiting and its attention dot, plus the [data-inbox-waiting="teammate"] variant. The marker's dot is now always muted, so the marker drops its data-inbox-waiting attribute.
  • The Factory's and the person page's own "Waiting on you" text is untouched.

Tests

  • desktop-inbox.test.ts: the assertions that expected "Waiting on you" now expect no marker. New tests: the reader's own open ask draws no waiting marker anywhere in the thread, and a teammate's open ask of an unknown type still names the teammate. The teammate marker test still asserts "Waiting on Charles Pan". It no longer checks the data-inbox-waiting attribute, which was styling wiring that no longer exists.
  • pnpm check:affected: lint passed. The typecheck step was OOM-killed (137) running three packages in parallel in the sandbox, so I ran typecheck for panel, desktop, and web one at a time, and all three exit 0. One unrelated test, integrations-page.test.ts, timed out under load and passes on its own. desktop-inbox.test.ts passes in full (178 tests).

Made with Luke

Devin Review