feat(panel): an answered ask's controls stand in its reply with no card around them
Merged
DA
5d ago+27+27+01234567890123456789-26-26-01234567890123456789
What this does
The developer: "I don't love how we have another box around options when answered. Can we clean that up?"
Since #4139 and #4224, an answered Inbox ask's read-only controls head the answering member's reply (AnsweredCard in inbox-pane.tsx). They sat inside an .inbox-ask card (border, background, rounded corners, 12px padding), and each option row has its own fill, so the options read as a box inside a box.
AnsweredCardnow draws its controls as.inbox-ask-answereddirectly in the reply's body, with no.inbox-askcard around them. They sit under "You" and the time, and their left edge matches the reply's words. This covers the option rows (the picked one selected, the Recommended badge kept), the yes/no and Mark done / Couldn't do it buttons with the pressed one marked, the ticked steps, and the filled fields..inbox-ask-answeredloses its padding and gets a 4px bottom margin. Added to the comment body's 8px gap, that leaves 12px between the controls and the reply's words, so the two don't run together. - Older single-item layout: no change was needed. Its answered controls (AnsweredResponse) already stand bare in the comment, with no box.- Not touched: the open ask and draft reply (#4194), the "Waiting on you" and "โ Answered" markers, and how a replaced ask is drawn.
- Removed the
.inbox-ask-bodyrule. Nothing has drawn it since #4194 moved the open ask's controls into the draft reply..inbox-askstays, since it still draws the replaced and withdrawn asks. - Rebased onto main after #4194 landed. Both changes are kept.
Screenshots (light, desktop profile)
Rendered from the inbox test harness's fixtures with the bundled panel stylesheet.
| Ask | Before | After |
|---|---|---|
| Pick one | ![]() | ![]() |
| Yes/no (Request changes, with words) | ![]() | ![]() |
| To-do (Mark done) | ![]() | ![]() |
| Form | ![]() | ![]() |
Tests
desktop-inbox.test.ts:answeredCardandansweredBoxnow check that the answered controls are a direct child of the reply's.inbox-comment-bodywith no.inbox-askaround them.askBoxesno longer counts an answered ask as a box. Without the change, 17 tests fail. The file passes alone (166/166).pnpm check:affectedcouldn't finish in the sandbox.discarded-effectwas OOM-killed, and two unrelated panel tests (agent-archive,tasks-page) timed out under load. CI runs the full set.
Made with Luke







