chore: cut the test suite and checks to an MVP's needs
Merged
CH
6d ago+882+882+012345678901234567890123456789-116756-116756-012345678901234567890123456789012345678901234567890123456789
Summary
- Cut the test suite to what an MVP needs: 426 test files become 165 (about 3,900 tests become 623), counting the 10 test files main added since, held to the same rules. Kept: account isolation, secrets and auth, session replay masking, user data loss, the desktop-server wire contract (
hosted-wire-schemasgolden), and one test per core flow (voice call, plan edit, sign-in, coding agent start), and the desktop's pure model tests (10 files, 92 tests) that go through public exports. - Removed
apps/web/tests/eve-layout.test.ts(96s, two realeve builds). A failed eve build still stops the deploy. - Removed
design/check-design-contract.mjsand five low-value rules fromscripts/repository-checks.sh(required-files list, SAFETY grep, scroll-snap, native<select>, changelog screenshots). - Removed
scripts/queue-watch.sh, the vendoredeffect-v3-to-v4skill, and thetest:harnessstep (no.mjstests remain). - CI's Postgres job now runs
db:migratealone;test:store(64s) andtest:agent(92s) still run by hand. The job keeps its name because the ruleset requires it. - Deleted production code only tests used (mostly test-support helpers and the per-refusal schemas in
http-effect.ts). Unused exports went throughknip --fix.runOnMacstays: main now calls it throughrunOnMacTool. - Fixed docs that named deleted tests or fixtures (
apps/web/server/README.md,docs/PLANNING.md,docs/DESIGN.md).
./scripts/check.sh goes from about 325s to 136s locally.
Evidence
- Platform-independent checks:
./scripts/check.shgreen on Linux (136s). - macOS Electron verification (
./scripts/verify.sh):not run. This PR deletes renderer dead code andbiome-ignorecomments; CI could not verify it on a Mac.
Visual evidence
- Fixture screenshots inspected:
not attached(no intended UI change)
Physical-device evidence
- Screenshot or screen recording:
not attached - Device/display configuration:
not recorded
Invariants
-
./scripts/check.shgreen.verify.shnot run (see above). - JSON Schema goldens unchanged: the wire-contract golden is unchanged; golden fixture folders used only by deleted tests were deleted (
apps/web/fixtures/{account-route,admin-refusal,hosted-refusal,events-maintenance-route,integrations-route},packages/live/fixtures/json-schema,tools/trace-export/fixtures). - No behavior change beyond deleting code nothing in production called; no change-detector test added.
- Gateway envelope goldens unchanged.
- No new
astype assertion. - No new
Effect.run*outside the edges. - No new raw async primitives.
- No discarded Effect.
- Test count: deliberately reduced from 426 files to 165 (623 tests remain).
- No hand-rolled file replaced.
- Root
AGENTS.mdedited (owner approved): CI runs neithertest:storenortest:agent, and the gonepackages/host/src/testing/builders are dropped. -
PRIVACY.mdunchanged. - Package deps match imports (
vitestdropped from workspaces with no tests). - Barrel/door rule unchanged.
Notes
- Blockers or follow-up verification: a
verify.shpass on a Mac.
š¤ Generated with Claude Code