feat(desktop): open a pull request from its hover card (SUPER-2977)
Merged
SU
12d ago+40+40+01234567890123456789-118-118-012345678901234567890123456789
Fixes SUPER-2977
Stacked on #9013 (SUPER-2978), which changes the same card. Merge that first; this PR's base then moves to main.
Problem
The GitHub hover card in the chat had no clickable way to reach the pull request or issue. On transcript chips its footer only said "Click the chip to open the pull request"; links in agent replies and composer chips had no hint at all.
Change
- The card's title now links to the pull request or issue.
- An Open on GitHub link (with an external-link icon) now sits at the bottom of every card. It shows while details load and when they are unavailable, so the way out is always there.
- Both go through the chat pane's
openLink, the same click policy the chip uses. Where there is no pane they fall back to a normaltarget="_blank"link. - I removed the
openHintprop and the two "Click the chip to open…" strings. "Open on GitHub" was already translated in every locale, so the catalog diff only removes lines.
Validation
- New test in
GithubWorkItemChip.test.tsx: clicking the card's title and then "Open on GitHub" each callopenLinkwith the PR URL. 18/18 pass in the folder. apps/desktoptypecheck passes. Biome is clean on the changed files.bun run check:i18nreports no missing messages.- I have not checked this in the running app.
Summary by cubic
Makes GitHub hover cards in the chat open their pull request or issue directly, instead of only hinting that the chip can be clicked.
- The card's title now links to the pull request or issue.
- A persistent Open on GitHub link with an external-link icon sits at the bottom, shown from the loading state onward.
- Both links route through the chat pane's
openLinkwhen a pane is available, and fall back to a normal_blanklink otherwise. - Removed the
openHintprop and the two “Click the chip to open…” strings; existing translations for “Open on GitHub” were already present, so only catalog deletions remain.