Add null type only test to Java okhttp-gson client
Merged
WI
2mo ago+47+47+01234567890123456789-3-3-0123456789
PR checklist
- Read the contribution guidelines.
- Run the following to build the project and update samples:
(For Windows users, please run the script in WSL)./mvnw clean package || exit ./bin/generate-samples.sh ./bin/configs/*.yaml || exit ./bin/utils/export_docs_generators.sh || exit
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*.
IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed. - If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
Summary by cubic
Adds a null-only schema property to the Java okhttp-gson 3.1 petstore sample to validate OpenAPI 3.1 type: null handling. This ensures the generator emits a nullable Object field and includes it in equality, hashing, and field validation.
- Spec: adds
second_propertywithtype: nulland description "just null type". - Model
PetWithTypesObjectNullAndRef: newsecondProperty(Object,@javax.annotation.Nullable), included inequals,hashCode,toString, andopenapiFields. - Docs:
PetWithTypesObjectNullAndRefnow listssecondPropertyas optionalObjectwith the description. - Adds
JsonNullablehelpers; they are not used and do not change behavior.
Review Notes
- Focus on generated Java for
okhttp-gsonto confirmtype: nullmaps to a nullableObjectand passes validation. - Regenerate samples to verify outputs stay consistent across generators.