fix: resolve ShellCheck issues mentioned in #24675
Merged
GE
2mo ago+3738+3738+0123456789012345678901234567890123456789-4539-4539-0123456789012345678901234567890123456789
Closes #24675
PR checklist
- Read the contribution guidelines.
- Run the following to build the project and update samples:
(For Windows users, please run the script in WSL)./mvnw clean package || exit ./bin/generate-samples.sh ./bin/configs/*.yaml || exit ./bin/utils/export_docs_generators.sh || exit
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*.
IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed. - If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
Summary by cubic
Fixes ShellCheck warnings in git_push.sh by using safer empty checks and clearer messages. Updates the _common/git_push.sh.mustache template and regenerates sample scripts to apply the fix. Closes #24675.
- Bug Fixes
- Replace [ "$var" = "" ] with [ -z "${var}" ] and keep quoted expansions.
- Use braces in echoes and escape variable names in info logs (e.g., print ${git_host} literally).
- Regenerate sample
git_push.shscripts across clients via./bin/generate-samples.sh ./bin/configs/*.yaml.