Better handling of cookie in python clients
Merged
WI
4mo ago+18+18+01234567890123456789-45-45-01234567890123456789
a follow up pr to https://github.com/OpenAPITools/openapi-generator/pull/24149
PR checklist
- Read the contribution guidelines.
- Run the following to build the project and update samples:
(For Windows users, please run the script in WSL)./mvnw clean package || exit ./bin/generate-samples.sh ./bin/configs/*.yaml || exit ./bin/utils/export_docs_generators.sh || exit
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*.
IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed. - If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
Summary by cubic
Improve cookie handling in Python clients by percent-encoding cookie auth values while preserving RFC 6265–safe characters (including +/=) so base64 and other valid cookies aren’t broken. This prevents malformed Cookie headers when values contain spaces or special characters.
- Bug Fixes
- Replace quote-wrapping with urllib.parse.quote(..., safe="!#$%&'()*+-./:<=>?@[]^_`{|}~%+/=") when building the Cookie header.
- Update
python/api_client.mustacheand regenerate Python samples (python,python-httpx,python-httpx-sync,python-aiohttp,python-lazyImports, legacy).