[java][restclient][webclient] add localVar prefix to queryParams variables
Merged
WI
5mo ago+1061+1061+0123456789012345678901234567890123456789-1061-1061-0123456789012345678901234567890123456789
add localVar prefix to avoid compilation errors due to name collisions.
another workaround is to use parameterNameMapping option: https://github.com/OpenAPITools/openapi-generator/blob/master/docs/customization.md#name-mapping
cc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)
PR checklist
- Read the contribution guidelines.
- Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
- Run the following to build the project and update samples:
(For Windows users, please run the script in WSL)./mvnw clean package || exit ./bin/generate-samples.sh ./bin/configs/*.yaml || exit ./bin/utils/export_docs_generators.sh || exit
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*.
IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed. - File the PR against the correct branch:
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks) - If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having
"fixes #123"present in the PR description) - If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
Summary by cubic
Adds the localVar prefix to the query param map in the Java restclient and webclient generators to prevent name collisions and align with existing naming. Regenerates samples and updates tests; no runtime changes.
- Refactors
- Renamed
queryParamstolocalVarQueryParamsinJava/libraries/restclient/api.mustacheandJava/libraries/webclient/api.mustache. - Regenerated Java
restclientandwebclientsamples. - Updated
JavaClientCodegenTestassertions to expectlocalVarQueryParamsin both JSON and non-JSON query serialization.
- Renamed