Fix #23903 by using method parameter names that are guaranteed not to…
Closed
GR
5mo ago+1421+1421+0123456789012345678901234567890123456789-1418-1418-0123456789012345678901234567890123456789
… conflict with variables in the same method.
PR checklist
- Read the contribution guidelines.
- Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
- Run the following to build the project and update samples:
(For Windows users, please run the script in WSL)./mvnw clean package || exit ./bin/generate-samples.sh ./bin/configs/*.yaml || exit ./bin/utils/export_docs_generators.sh || exit
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*.
IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed. - File the PR against the correct branch:
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks) - If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having
"fixes #123"present in the PR description) - If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
Summary by cubic
Prevents name collisions in generated Java RestClient methods by prefixing all method parameters with "__", fixing cases where params shadow local variables. Fixes #23903.
- Bug Fixes
- Updated
modules/openapi-generator/src/main/resources/Java/libraries/restclient/api.mustacheto emit__paramNamefor all method parameters (including Javadoc). - Applied the change across query, path, header, form, multipart, and body handling in request-creation methods.
- Regenerated Java RestClient samples and updated tests (e.g., expect
if (__filter != null)), ensuring no param/variable conflicts.
- Updated