A follow-up PR to #22726 (update workflow, samples)
Merged
WI
5mo ago+34+34+01234567890123456789-8624-8624-0123456789012345678901234567890123456789
a follow-up pr to #22726
PR checklist
- Read the contribution guidelines.
- Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
- Run the following to build the project and update samples:
(For Windows users, please run the script in WSL)./mvnw clean package || exit ./bin/generate-samples.sh ./bin/configs/*.yaml || exit ./bin/utils/export_docs_generators.sh || exit
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*.
IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed. - File the PR against the correct branch:
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks) - If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having
"fixes #123"present in the PR description) - If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
Summary by cubic
Streamlined the Spring HTTP Interface OAuth sample to a minimal Petstore “addPet” client and wired it into the JDK17 workflow to speed up generation and CI validation.
-
Refactors
- Switched generator input to
modules/openapi-generator/src/test/resources/3_0/petstore-addpet-only.yaml. - Renamed sample artifact to
spring-http-interface-oauth-petstore. - Pruned generated code to only
PetApiand related DTOs; removed unused APIs/models and beans. - Updated
PetApi.addPetto returnResponseEntity<PetDto>and acceptapplication/jsonandapplication/xml. - Changed
PetDto.photoUrlsfrom Set to List; madeCategoryDto.namenullable and removed default; updated model docs. - Simplified README and allowed it to be regenerated by removing the ignore rule.
- Switched generator input to
-
CI
- Added
samples/client/petstore/spring-http-interface-oauth/**to the Spring JDK17 workflow triggers and build matrix.
- Added