[Java] [vertx] Make supportVertxFuture compatible with vertx 5

Merged
RI
7mo ago
+28328-94

Closes #23659

In vertx 5, Promise no longer extends Handler<AsyncResult>, which means we can't directly pass in a promise into an arg that accepts a handler. However, promise::handle still works, in both versions of vertx.

Also added a new sample java-vertx5-supportVertxFuture to the samples.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)


Summary by cubic

Make supportVertxFuture compatible with Vert.x 5 by switching generated calls to promise::handle, keeping Vert.x 4 support. Adds a Vert.x 5 Petstore sample and updates CI to build it.

  • Bug Fixes

    • In Java/libraries/vertx/api.mustache, use promise::handle in default Future helpers (and auth variants) instead of passing the Promise directly.
    • Update existing samples/client/petstore/java/vertx-supportVertxFuture APIs to use promise::handle.
  • New Features

    • Add Vert.x 5 sample: samples/client/petstore/java/vertx5-supportVertxFuture with config bin/configs/java-vertx5-supportVertxFuture.yaml (useVertx5: "true", supportVertxFuture: "true").
    • CI: include the new sample in .github/workflows/samples-java-client-jdk11.yaml.