Add scalafmt (plugin) to scala-sttp4 client
Merged
WI
7mo ago+138+138+012345678901234567890123456789-2-2-0123456789
cc @clasnake (2017/07), @shijinkui (2018/01), @ramzimaalej (2018/03), @chameleon82 (2020/03), @Bouillie (2020/04) @fish86 (2023/06)
PR checklist
- Read the contribution guidelines.
- Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
- Run the following to build the project and update samples:
(For Windows users, please run the script in WSL)./mvnw clean package || exit ./bin/generate-samples.sh ./bin/configs/*.yaml || exit ./bin/utils/export_docs_generators.sh || exit
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*.
IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed. - File the PR against the correct branch:
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks) - If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having
"fixes #123"present in the PR description) - If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
Summary by cubic
Adds Scalafmt to the Scala STTP v4 client generator to ensure consistent formatting. The generator now outputs a .scalafmt.conf and enables the sbt-scalafmt plugin.
-
New Features
- Generates
.scalafmt.conf(Scalafmt 3.10.6, Scala 2.13 dialect). - Adds
project/plugins.sbtwithorg.scalametasbt-scalafmt2.5.6. - Updates Scala STTP v4 samples to include these files.
- Generates
-
Refactors
- Stops generating
DateSerializers.scala.
- Stops generating