feat(php): allow to pass raw boolean to api
Merged
SI
2y ago+528+528+012345678901234567890123456789-179-179-012345678901234567890123456789
This allows users to use APIs that require booleans in query params not to be cast to int, e.g. &foo=true. Currently, true is cast to 1 so it's passed as &foo=1. That might not be supported by the target API.
The fix contains copy-pasted function from guzzlehttp/psr7 Query::build() with minor tweaks.
https://github.com/guzzle/psr7/blob/540ec79fb2f2e96591febb0de464bc16ac2ea341/src/Query.php#L73
Related to https://github.com/OpenAPITools/openapi-generator/issues/2204
There's a proposal by me to include the functionality in guzzlehttp/psr7 https://github.com/guzzle/psr7/pull/603
PR checklist
- Read the contribution guidelines.
- Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
- Run the following to build the project and update samples:
(For Windows users, please run the script in Git BASH)./mvnw clean package ./bin/generate-samples.sh ./bin/configs/*.yaml ./bin/utils/export_docs_generators.sh
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*.
IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed. - File the PR against the correct branch:
master(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks) - If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.