fix(ci): danger node 24 compatibility

Merged
LU
3mo ago
+5-0

Summary

Fixed failing danger/danger job on Node 24 by:

  1. Upgrading central danger.js workflow to ^13 (uses WHATWG fetch/undici instead of node-fetch v2)
  2. Pinning node version to 20 as temporary safety measure until danger@14+ ships

Root Cause

danger@12 bundles node-fetch v2, which fails with ERR_STREAM_PREMATURE_CLOSE on Node 24. GitHub runners default to Node 24 as of 2026-06-29.

Fix

  • Updated LucasSantana-Dev/.github/.github/workflows/danger.yml:
    • danger_version: ^13 (latest 13.0.10 supports Node >=18)
    • node_version: 20 (temporary pin; revert after danger@14+ stable in wild)
  • Updated docs/review-tools.md maintenance section with deprecation note

Verification

The danger check on this PR should now run green (was failing on all PRs since 2026-06-29).

Closes #1654

Summary by cubic

Fixes failing Danger CI on Node 24 by upgrading the central workflow to danger@^13 and temporarily pinning Node to 20. Notes added in docs/review-tools.md and dangerfile.ts. Closes #1654.

  • Bug Fixes
    • Root cause: danger@12 depends on node-fetch@2, which breaks on Node 24.
    • Central workflow updated to danger@^13; Node pinned to 20 for now and will be unpinned after danger@14+ is stable.

Summary by CodeRabbit

  • Documentation
    • Updated maintenance notes with the latest workflow compatibility guidance.
  • Chores
    • Recorded an upgrade to the review automation tooling for Node 24 support.
    • Added a reminder to revisit the Node version pin after the newer release is proven stable.