🛡️ Sentinel: Fix unvalidated User-Agent input in IPC and HTTP client

Closed
JU
7d ago
+56-3

User description

🚨 Severity: MEDIUM / HIGH
💡 Vulnerability: update_subscription_user_agent IPC command accepted arbitrary string inputs without checking length or control characters (\r, \n, \0). Persisting invalid header values into settings caused HTTP client creation during subscription downloads to fail permanently, resulting in persistent DoS.
🎯 Impact: Unvalidated User-Agent input could lead to settings bloat, HTTP header injection, and persistent failure of background subscription updates.
🔧 Fix:

  • Added validate_user_agent in crates/core/src/config/subscription.rs enforcing max 512 bytes length and rejecting control characters (\r, \n, \0).
  • Enforced validate_user_agent in update_subscription_user_agent in apps/desktop/src-tauri/src/lib.rs.
  • Added defensive fallback in build_http_client_with_proxy in apps/desktop/src-tauri/src/core/subscription.rs to default to Zephyr User-Agent if an invalid UA is provided.
  • Added unit tests for validate_user_agent in crates/core/src/config/subscription.rs.
    ✅ Verification: Executed unit tests (cargo test -p zephyr-core), all 264 unit tests passed.

PR created automatically by Jules for task 2142103409973242462 started by @Juwan-Hwang

CodeAnt-AI Description

Prevent invalid User-Agent settings from stopping subscription updates

What Changed

  • Rejects custom User-Agent values over 512 bytes or containing control characters before saving them.
  • Trims surrounding whitespace from saved values and uses the default User-Agent if a saved value is invalid.
  • Subscription downloads can continue instead of failing when an invalid User-Agent is encountered.

Impact

✅ Fewer subscription update failures
✅ Invalid User-Agent values rejected before saving
✅ Custom User-Agent whitespace removed

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.