android: drop A26, A33 and A48 — the game window path returns to upstream

Merged
JO
5d ago
+47-6

What this drops

Three patches that each changed how the compositor decides which window is the game, at a cost that turned out to be larger than what they bought:

patchwhat it didwhy it goes
A26 uniform app idforced w->appID = 1 for every windowits only real consumer is the app_perf_requests channel, and nothing calls it: no requestAppPerformanceStats and no GAMESCOPE_APP_ID in the app, and the daemon's allowlisted concommands never ask for per-app stats. Meanwhile it made windows_share_app, is_same_app_override_decoration and is_good_override_candidate vacuous
A33 blank while the game window is absentpainted a blind at the transitionsits premise is A26's damage: "the app-id cannot tell the game's window from the desktop's". With A26 gone the app id distinguishes them again, so 199 lines of commit-surface and binding-time inference are inferring something that is now directly knowable
A48 bring nested app window to frontasked winhandler.exe over UDP/7946 to raise any nested child whose class was not explorer.exe/tabtip.exe and whose size was over 1×1with A26 gone its deny list is the only filter, so any win32 window that maps qualifies — an error dialog, an installer, Steam's login. The app-id test it lost is available again

Removing them leaves the window path at upstream semantics, plus A49 (reaper nudge) and A27/A28 (session lifetime here) — patches about when the session ends, not about which window is real.

Confirmed on device

OMORI (app id 1150690) flashed — game image / black / game image — and stops flashing with these three removed. Verified on the same build, same title, same scene.

That is the strongest argument for the set: the flashing tracked a patch that answers MapNotify, in a session where nothing about the guest's rendering changed.

Risk, stated plainly

A48 is the only one with a functional risk. If something in the wine virtual desktop does not raise a nested game window on its own, removing A48 leaves that window behind the desktop — desktop background on screen, or input not reaching the game. A48's own comment says the app's X11 server already answers every map with WinHandler.bringToFront; if that is live in this route too, A48 was a duplicate and this is pure deletion. Worth one launch per Proton version (9 and 10) on a title that maps a nested child, checking: game appears without the desktop background, input reaches it, rate unchanged.

If it does regress, the fix is the predicate A48 should have had rather than the deny list: raise only when the mapping window shares the app id of the focus, or is guest-owned by the reaper's own test.

Not in this PR

The shim-side spare-ring switch (GN_VKSHIM_NO_SPARES) is a gamenative-drm change and belongs there; it addresses a different flashing signature (an unwritten copy published on alternate presents), not this one.