Fix the 10 to 12 November PR review findings (D-159)

BI
3h ago
+1542-707

Requested by josh · project thread

What

Fixes the 16 findings from the review of the 48 PRs merged 10 to 12 November (#1584 to #1635). Josh answered "Yes to all" (12 Nov 04:04 UTC), recorded as D-159.

Design

  1. Ward top: the New referral chip is phone-only (D-116). Off the phone, the bar's New menu and the bed's own "Raise ward referral" stay.
  2. DESIGN-SYSTEM page header rule now says one on-hero button plus one quick-link chip row (v6).
  3. Home's Waiting in ED strip on a tablet (46.5 to 64rem) keeps whole words and scrolls sideways.
  4. Eight rows then Show more: Night view lists, Capacity intake-windows and closed-beds cards, Leave (opens fully for print), handover own work and promises ("Show list").
  5. Leave moves onto the band hero, with on leave, due back today and overdue as figures.
  6. Print and Export are icon-only on phones on Movements, Leave and Legal forms. Both use the kit's default 36px desktop size, so Export grows on other screens too. Legal forms passes the card meta only when it has text.
  7. Kit sizes: under-18 Save, Midland find box, phone search chips (40px, tokens, labels clip at 320px), Night view link. The under-18 status line stays mounted. Intake hours use TimeField.
  8. Transport choices read "Still waiting" and "Gone with transport".
  9. Outage catch-up buttons name what they open. The footnote counts the beds that are actually unconfirmed.

Behaviour
10. Chip rows use touch-action: pan-x pan-y with overflow-y: hidden, so the page scrolls from a row. Checked in emulation only; please try it on a real iPhone.
11. One ready count (D-115). readyBedsNow and its siblings now require the holds. Tools, statistics chart, rail tracker, broadcast audience, peek and search previews pass the movements and referrals.
12. One ended Form 5A/5B wording through legalFormEnd(): export, Home list, patient glance and ward derivations.
13. Uptime opens the sign-in or workspace issue before failing on a hidden database check.
14. Demo-code limit: a WARD_TRUSTED_PROXY_ADDRESSES list other than * is ignored with one warning, falling back to D-147 per-address keying.
15. Home's loading hold uses opacity: 0 and yields to focus, in place of visibility: hidden. This needs a CLS re-measure in the browser lane.
16. Wording: the D-79 boundary sentence is fixed. The Night view title follows the service scope, and its figures scope exactly as Home's do. The MHERL example now reads "joint assessment with the WA Police co-response team, referred through MHERL". That wording is my suggestion for Josh to check.

Evidence

  • Local, Node 24:
    • tsc -p tsconfig.typecheck.json: clean.
    • ESLint and Prettier on every changed file: clean.
    • docs:facts: current, with D-159.
    • Owner-rulings index: current.
    • check:ward-raw-colour: no rise.
  • Full vitest suite, 3 shards, 23,698 tests: 3 failed on the first run.
    • ward-review-engine used the removed desktop chip. It now uses the bed's "Raise ward referral".
    • ward-no-invented-screen-figures flagged the "24-hour" hint. The hint now reads "HH:MM".
    • The source-text ratchet flagged ward-home-cards-pending-reachable. It is listed with a reason: it reads CSS because jsdom cannot compute the hold.
    • Those three now pass. The full suite was not re-run after them.
  • Not run locally: Playwright, browser lanes and visual baselines (they need CI), the Next build, and the phone size limits (script-budget.json). Leave and Legal forms phone code grew a little.

Not changed

No signed clinical value, time limit or clinical rule. No release.

Generated by Claude Code