#3567 fix: resolve 16 open non-RAG issues across roster, on-call, reindex, UI virtualization, browser matrix, and monoliths

User description

Summary

• Pod 1 — Roster & On-Call Backend Safety (#7JJWKH, #MS6VXW, #HEWR5X):
  • #7JJWKH: Replaced per-service N+1 count queries in listOwnerTeams (src/lib/roster/owner/teams.ts) with chunked 40-service .in("service_id", ...) queries and 1,000-row .range(...) pagination loops.
  • #MS6VXW: Added detectOwnConflicts (src/lib/roster/shifts/conflicts.ts) and wired own-shift overlap warnings into diffRoster (src/lib/roster/shifts/diff.ts), checkManualShiftConflicts (src/lib/roster/shifts/repository.ts), and POST /api/roster/shifts/manual.
  • #HEWR5X: Extended adminFreeTextProblem (src/lib/on-call/free-text-guard.ts) across all On Call sections with recursive details scanning (MAX_DETAILS_DEPTH = 8 + WeakSet cycle guard) and anchored DOB validation.
• Pod 2 — Developer Ledger, CI Entrypoints & Source Governance (#315621, #2S5NFB, #49Q5FB, #237JN5, #VWNEQ0, #WBQ6MC):
  • #315621: Added inboxRecordSchema and per-file try/catch + safeParse validation in readDevPendingRequests (src/lib/developer-area/ledger-snapshot.ts) so a corrupt or schema-invalid inbox file is skipped without dropping valid sibling requests.
  • #2S5NFB: Added scripts/lib/is-entrypoint.mjs to .github/workflows/live-domain-monitor.yml sparse-checkout, converted scripts/check-live-deployment-freshness.mjs and scripts/check-live-search-results.mjs to isDirectEntrypoint, and emptied ALLOWED_RAW in tests/script-entrypoint-guard.test.ts.
  • #49Q5FB: Refreshed docs/release-source-metadata-debt-2026-06-30.json with verified zero-debt status (missing_required_metadata_count: 0, status: "resolved_zero_missing_metadata") and added tests/source-metadata-debt-waiver.test.ts.
  • #237JN5 & #VWNEQ0: Added eslint-rules to lint:internal in package.json, named default export in eslint-rules/restrict-suppress-hydration-warning.mjs, clarified .github/workflows/sast.yml, and updated stale tier header comments in scripts/check-type-scale.mjs, scripts/check-codebase-index-coverage.mjs, and scripts/check-docs-script-refs.mjs.
  • #WBQ6MC: Moved tests/work-page-favourite-visibility.dom.test.tsx from docs/organisation/systems/data-platform.json to docs/organisation/systems/personal-practice.json.
• Pod 3 — Reindex Reaper, Hostile Document Ingestion & Clinical Safety Anchors (#RP00FZ, #F3SGCM, #5PNWGR):
  • #RP00FZ: Added buildAbandonedGenerationStorageCleanupJobs, filterReapableAbandonedGenerations, and clampAbandonedCleanupLimit (src/lib/reindex-pipeline.ts, scripts/cleanup-abandoned-reindex-generations.ts) to enqueue storage cleanup jobs for orphaned reindex objects while protecting committed/active generations and legacy documents.
  • #F3SGCM: Created executable 7-class hostile-document ingestion test matrix (tests/hostile-document-ingestion-matrix.test.ts).
  • #5PNWGR: Updated all stale file:line citations in docs/clinical-hazard-analysis.md and docs/rag-injection-threat-model.md and added tests/clinical-doc-line-anchors.test.ts.
• Pod 4 — Search Result Virtualization & Bundle Budget (#CFHRJY, #VHR3TJ):
  • #CFHRJY: Added SSR-deterministic VirtualizedResultList (src/components/ui/virtualized-result-list.tsx) with responsive CSS grid column detection and integrated into src/components/clinical-dashboard/document-search-results.tsx and src/components/differentials/differential-stream-workspace.tsx.
  • #VHR3TJ: Documented bundle-budget.json ceiling provenance and added regression assertions in tests/bundle-budget.test.ts.
• Pod 5 — Browser Matrix & Specifiers Settlement (#HN9RD0, #33346A, #9Z197J):
  • #HN9RD0: Replaced visibleByText with expectSingleSettledOwner in tests/ui-specifiers.spec.ts.
  • #33346A & #9Z197J: Fixed Gecko <details> toggle loop and rAF hit-step latch in src/components/document-viewer/source-panels.tsx, added collision-safe useId() and persistent <h2 className="sr-only"> to the tools complementary panel (src/components/tools/tools-search-results-page.tsx), added expectHydrated settlement guards in tests/ui-smoke.spec.ts and tests/ui-tools.spec.ts, and added tests/browser-matrix-regressions.dom.test.tsx.
• Pod 6 — Monolith Decomposition (#H9WAQN):
  • #H9WAQN: Extracted 12 cohesive modules from src/components/ClinicalDashboard.tsx (3,812 -> 3,544 lines), src/components/clinical-dashboard/master-search-header.tsx (3,234 -> 2,579 lines), and src/app/globals.css (src/styles/globals-keyframes.css), verified by tests/monolith-decomposition-integrity.test.ts.

Areas touched: Knowledge and records, App experience, Personal practice, Delivery and assurance, Design system, Clinical reference content, Source intake and indexing, Answer engine, Prototypes, Data platform and access

Verification

• Checks run:
  • npm run lint -> [gate-receipts] recorded a pass for "lint:internal" (10119 input files).
  • npx tsc -p tsconfig.typecheck.json --noEmit -> 0 errors
  • npm run check:organisation -> organisation: exit 0 (pass) — working tree (10119 files: 10114 placed, 4 shared, 1 ignored, 0 not yet placed, 0 unplaced)
  • npm run docs:maintain:check -> CLINICAL_HAZARD_CONTROLS_PASS hazards=7 decisions=5 review-dates=strict expired-not-blocking=0
  • npm run check:ledger-write-discipline -> Ledger write discipline passed for 0e04b21641d2..HEAD.
  • Focused Vitest suites (tests/roster-owner-teams.test.ts, tests/roster-own-shift-conflicts.test.ts, tests/on-call-free-text-guard.test.ts, tests/developer-ledger-snapshot.test.ts, tests/script-entrypoint-guard.test.ts, tests/source-metadata-debt-waiver.test.ts, tests/reindex-reaper-storage-cleanup.test.ts, tests/hostile-document-ingestion-matrix.test.ts, tests/clinical-doc-line-anchors.test.ts, tests/search-results-virtualization.dom.test.tsx, tests/bundle-budget.test.ts, tests/browser-matrix-regressions.dom.test.tsx, tests/monolith-decomposition-integrity.test.ts) -> 13 passed (13), 439 passed (439)

Risk and rollout

• Risk: Low-to-moderate; changes span non-RAG backend helpers, UI virtualization above 30 items, browser settlement fixes, documentation line anchors, and internal component extractions. Zero RAG retrieval/ranking/answer-generation logic or database migrations were touched.
• Rollback: Standard single-commit revert of this PR; no schema or persistent data format changes.
• Provider or production effects: None

Notes

• All 6 pod changes underwent an independent adversarial review pass before commit (adding PostgREST 1,000-row pagination in listOwnerTeams, recursion depth + cycle guards in free-text-guard.ts, SSR-deterministic rendering and CSS grid column detection in VirtualizedResultList, and preserving all existing tests in developer-ledger-snapshot.test.ts).

Summary by cubic

Resolves 16 open issues spanning roster and on-call safety, reindex cleanup, search-result UI virtualization, browser reliability, developer tooling, and code organization. Large result lists now virtualize, and several backend and UI edge cases gained regression coverage. No RAG retrieval, ranking, or answer-generation changes and no database migration.

• Batch roster owner-team membership counts with pagination and deterministic row ordering, and warn (non-blocking) about overlapping shifts in roster diffs and manual shift entry.
• Scan all on-call free-text fields for patient identifiers, which must contain digits, down through nested details.
• Validate developer inbox records independently so a malformed file is skipped without dropping valid siblings; bound temp-dir cleanup retries in the new tests.
• Queue abandoned reindex storage cleanup that retries until deletion succeeds and covers all deleted generations, while never touching active or committed generations.
• Virtualize document and differential result lists with responsive-column detection and list-relative scrolling; the computed-height spacers raise the inline-style ratchet ceiling accordingly.
• Fix browser-specific interaction and hydration issues: Gecko details toggle loop, rAF hit-step latch, hydration settlement guards, and single settled owners for ambiguous badges.
• Extract dashboard, search-header (actions, scope picker, types), keyframes, and CSS modules; repoint contract tests and doc anchors at the decomposed files, and refresh governance checks such as the Semgrep scan targets (now including eslint-rules).

Summary by CodeRabbit

• New Features
  • Large search and differential-result lists now use a responsive, keyboard-accessible view.
  • Search controls offer expanded document-scope and filtering options.
  • Roster imports and manual shift changes now report overlapping shifts.
• Bug Fixes
  • Improved document-viewer navigation, tool-panel accessibility, and roster data loading.
  • Clinical free-text checks now cover more sections and nested details.
  • Reindex cleanup better handles abandoned generations and orphaned files.
• Documentation
  • Updated clinical safety guidance and verification references.

CodeAnt-AI Description

Large search results now scroll smoothly, while roster conflicts and unsafe cleanup are handled safely

What Changed

• Large document, service, and differential result lists render as users scroll, replacing “Show more” controls for document and service results.
• Roster imports and manual shift entries report overlapping shifts as warnings without blocking the save.
• On Call free-text fields now reject patient identifiers across all sections, including nested details.
• Abandoned reindex cleanup queues orphaned images while preserving committed and in-progress files.
• Large owner team lists load counts in batches and include results beyond a single 1,000-row page.

Impact

✅ Smoother scrolling through large search results
✅ Earlier warnings for overlapping shifts
✅ Patient identifiers blocked across On Call sections
✅ Abandoned reindex images cleaned without deleting active files

@codeant-ai ask: Your question here

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

@codeant-ai: Your feedback here

@codeant-ai: Do not flag unused imports.

@codeant-ai: review