#3523 Keep both stages in the admission/discharge comparison answer evidence

User description

Requested by Josh · project thread

Summary

Before: "Compare admission and discharge requirements" is declined. Search ranks the Admission of Community Patients guideline in its top 5 (golden case passes), but answer-evidence selection fills every slot with discharge documents. The source-bound admission/discharge builder therefore has no admission source and fails closed. This is the only blocking failure in the weekly answer check (baseline run 38345051424; also run 38363682098).

After: when the selected fallback evidence has no exclusively labelled source for one stage, up to three of that stage's chunks are appended from the governed eligible set. The builder can then cite both stages.

How: withAdmissionDischargeSideEvidence (in rag-extractive-answer.ts) runs only for queries that isAdmissionDischargeRequirementsComparisonQuery matches. It is applied in rag.ts to the generation-fallback evidence. Candidates come from selectAnswerRouteEvidence's eligible set, which now also returns eligibleResults, so governance filtering still applies. A dual-title policy, such as "Referral, Admission and Discharge", does not count as a side. The builder's requirement binding and the claim-support gates are unchanged.

Areas touched: Answer engine
RAG impact: behaviour change — canary pair 38345051424 -> post-merge dispatch (pending)

Verification

• npm run test:focused on the changed files: 70 files, 1669 tests passed.
• Three new tests: the missing side is added and the builder cites both; the selection is unchanged when both sides are present or the query differs; a dual-title policy does not count.
• eslint and tsc --noEmit are clean.
• Live proof: one paid answer canary after merge, compared with 38345051424. A regression means a single-commit revert.

Risk and rollout

• Risk: low. This changes only the evidence passed to the fallback for this one comparison shape. Retrieval scores, ordering and the answer gates are unchanged.
• Rollback: revert this single commit.

Clinical Governance Preflight

• No clinical content is added. Appended evidence comes only from the governed eligible set. Every claim still needs a source-bound requirement sentence and claim support. If a stage has none, the answer still fails closed to the evidence-gap message.
• Sign-off: draft. Josh decides when it goes live.

🤖 Generated with Claude Code

https://claude.ai/code/session_014qdvjGwiFXsvPu5bTPL4bs

Generated by Claude Code

Summary by cubic

Fixes "Compare admission and discharge requirements" answers failing closed when answer-evidence selection fills every slot with one stage's documents, now in both the extractive-first and generation fallback paths.

• Appends up to three chunks of the missing stage from the governed eligible set when the selected evidence has no bound requirement for that stage; an unbound admission chunk or a dual-title policy such as "Referral, Admission and Discharge" does not count, and a chunk yielding several facts is added once. A single document supplying both sides also gets a second document topped up.
• The selection is unchanged when both sides are present or the query is not this comparison.
• selectAnswerRouteEvidence now returns the eligible results. Under governed context packing, top-up candidates must pass the same admission receipt the packer checks; top-ups are added to the related-document lookup so cited documents retain their metadata. The logic lives in its own module rag-admission-discharge-side-evidence.ts.
• Retrieval scoring, ordering, and the answer gates are unchanged; a side with no bound requirement still fails closed.

CodeAnt-AI Description

Include missing admission or discharge evidence in comparison answers

What Changed

• Admission/discharge requirements comparisons now include eligible evidence for a missing stage in both extractive and generated fallback answers.
• Answers still require source-backed requirements for both stages; without supporting evidence, they remain withheld rather than presenting a one-sided comparison.

Impact

✅ Both stages cited when eligible sources exist
✅ Fewer comparisons stop at an evidence gap
✅ Unsupported one-sided answers remain blocked

@codeant-ai ask: Your question here

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

@codeant-ai: Your feedback here

@codeant-ai: Do not flag unused imports.

@codeant-ai: review

Summary by Gitar

• Extractive-first path:
  • Applies the same side-evidence top-up in rag.ts before the validated extractive short-circuit
• Governed context packing:
  • Top-up candidates must pass contextPackAdmissionMatches, the admission receipt the packer requires
• Related documents:
  • Top-up chunks feed the related-document lookup so cited stages keep their entries

_{This will update automatically on new commits.}