fix: pin release-v0.8.5 gate to constant version (unblocks all PRs)
What does this PR do?
Fixes a stale release-gate test that is broken on main and blocks every current PR (observed on #918 and #854).
release-v0.8.5-adversarial.test.ts → "docs point at the action patch…" derived the version from the CHANGELOG's top entry and asserted it equals hardcoded "0.8.5". Once 0.8.6 shipped, the top entry became 0.8.6 → the assertion permanently fails (Expected "0.8.5", Received "0.8.6"). Only the 0.8.5 gate has this pattern (0.8.6's does not).
The 0.8.5 gate is release-specific (docs must reference the patched @v0.8.5, not the broken @v0.8.4). Fix: pin to the constant "0.8.5" and assert that changelog entry exists rather than that it is the latest. The docs assertions are unchanged and already pass.
Type of change
- Bug fix (non-breaking change which fixes an issue)
Issue for this PR
Closes #922
How did you verify your code works?
release-v0.8.5-adversarial.test.tsnow passes (13/13; was failing on the version assertion).- Confirmed the breakage is pre-existing on
main(independent of feature work) and that only the 0.8.5 gate uses the changelog-top pattern. - Marker guard clean (test-only change).
Checklist
- My code follows the style guidelines of this project
- I have performed a self-review of my code
- I have added tests that prove my feature works
- New and existing unit tests pass locally with my changes
Summary by cubic
Pin the v0.8.5 release-gate test to "0.8.5" and assert the changelog entry exists, fixing a failure on main and unblocking all PRs.
- Bug Fixes
- Stop deriving the version from the CHANGELOG’s top entry; use "0.8.5" and check for
## [0.8.5]. - Keep the docs checks as-is to ensure they reference
@v0.8.5(not@v0.8.4).
- Stop deriving the version from the CHANGELOG’s top entry; use "0.8.5" and check for
Summary by CodeRabbit
- Tests
- Updated test verification for changelog entries to explicitly validate version-specific header presence in documentation.