test: pin the workspace dev override to a non-production mount path
Merged
RA
2mo ago+25+25+01234567890123456789-6-6-0123456789
Issue for this PR
Closes #1392
Type of change
- Bug fix
- New feature
- Refactor / code improvement
- Documentation
What does this PR do?
Follow-ups to #1360, from its review:
- The
ALTIMATE_WORKSPACE_WEB_URLdev-override tests now use/dev/wsinstead of/workspaces, the production path. A mount hardcoded in the URL builders would pass a test that happens to use the same path; with a distinct one it fails. A new case also checks the cancel bounce under the override. docs/docs/usage/cli.mdlistsALTIMATE_WORKSPACE_WEB_URLin the environment-variable table, and says it must include the mount path. An old root-only value opens/create-and-linkat the root.
No runtime change.
How did you verify your code works?
browser-handoff.test.ts: 26 pass. With the join changed to hardcode /workspaces as the mount, both override tests fail (5 failures in all). Marker guard passes.
Checklist
- I have tested my changes locally
- I have not included unrelated changes in this PR
š¤ Generated with Claude Code
https://claude.ai/code/session_01LXpVmgHbm9Qzn54SQPpqDK
Summary by cubic
Pins the workspace dev-override tests to the /dev/ws mount path so a hardcoded /workspaces mount in the URL builders can no longer pass them, and documents ALTIMATE_WORKSPACE_WEB_URL in the CLI reference with the mount-path requirement. Adds a cancel-bounce assertion to the dev-override test.
Summary by CodeRabbit
- Documentation
- The CLI reference now documents the development-only
ALTIMATE_WORKSPACE_WEB_URLsetting. It lets developers override the tenant base URL used for browser hand-offs and workspace links; include the desired mount path in the URL.
- The CLI reference now documents the development-only